Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libp2p-deflate] Ensure read buffer is initialised. #1933

Merged
merged 3 commits into from
Jan 27, 2021
Merged

[libp2p-deflate] Ensure read buffer is initialised. #1933

merged 3 commits into from
Jan 27, 2021

Conversation

romanb
Copy link
Contributor

@romanb romanb commented Jan 25, 2021

Addresses #1932, i.e. the possibility to read uninitialised memory.

@romanb romanb linked an issue Jan 25, 2021 that may be closed by this pull request
Undefined data exposed in DeflateOutput's AsyncRead implementation #1932
Closed
mxinden
mxinden approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

//CC @ammaraskar

@romanb
Copy link
Contributor Author

romanb commented Jan 27, 2021

I will make a patch release of libp2p-deflate upon merging.

@romanb romanb merged commit 6d0773b into libp2p:master Jan 27, 2021
@romanb romanb deleted the meminit branch January 27, 2021 12:29
@ammaraskar
Copy link

Thank you for the fix, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undefined data exposed in DeflateOutput's AsyncRead implementation
3 participants
@romanb @ammaraskar @mxinden